actions/auth
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Security considerations: ids are strings, not integers (#400)

Browse Source 
Fix doc regarding using assertion on IDs rather than names. They refer
to IDs as integers, where those are actually strings, so we need to
quote them.

I lost too many hours on this to let anyone else experience the same
issue :D

Signed-off-by: Joachim Jablon <ewjoachim@gmail.com>
This commit is contained in:
Joachim Jablon 2024-03-12 16:21:38 +01:00 committed by GitHub
parent 55bd3a7c6e
commit 33e827c6cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/SECURITY_CONSIDERATIONS.md
View File

@ -40,7 +40,7 @@ curl -sfL -H "Accept: application/json" "https://api.github.com/repos/${REPO}" |
These can be used in an Attribute Condition:
```cel
assertion.repository_owner_id == 1342004 && assertion.repository_id == 260064828
assertion.repository_owner_id == '1342004' && assertion.repository_id == '260064828'
```
[cybersquatting]: https://en.wikipedia.org/wiki/Cybersquatting