Rewrite mostly useless assert in test_trans.py (#3810)

This PR updates an assert statement that checks the bounds of a
string-slicing operation. The updated assertion provides more accurate
and informative error handling by specifically checking the relative
values of the indices and the string length.

The original assertion was essentially checking if Python's string
slicing was behaving as expected. However, it wasn't providing any
guarantees or useful information about the bounds i and j themselves.

The updated assertion checks that the indices used for slicing are
within the bounds of the string. It will throw an AssertionError if the
indices are out of bounds or if i > j, providing a more specific and
informative error.
This commit is contained in:
freddiewanah 2023-07-28 02:51:28 +10:00 committed by GitHub
parent d9d0a02d89
commit 133af57207
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -13,7 +13,7 @@ def check(
# a glance than only spans
assert len(spans) == len(expected_slices)
for (i, j), slice in zip(spans, expected_slices):
assert len(string[i:j]) == j - i
assert 0 <= i <= j <= len(string)
assert string[i:j] == slice
assert spans == expected_spans