actions/black
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

expression tests: adjust starred expression for Python 3.9 (#1441) (#1477)

Browse Source 
As discussed in #1441, Python 3.9's new parser will not parse
`(*starred)` even using `compile()` with the `PyCF_ONLY_AST`
flag (as `ast.parse()` does), it raises a `SyntaxError`. This
breaks the four tests that use this file with Python 3.9.
Upstream does not consider this to be a bug - see
https://bugs.python.org/issue40848#msg370643 - so we must
adjust the expression. As suggested by @JelleZijlstra, this just
adds a comma, which makes the new parser happy with it (the old
parser is fine with this form also).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2020-06-03 15:15:54 -07:00 committed by GitHub
parent fcf9796106
commit 88d12f88a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/data/expression.diff
View File

@ -179,7 +179,7 @@
-((i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c'))) -((i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c')))
+((i ** 2) for i, _ in ((1, "a"), (2, "b"), (3, "c"))) +((i ** 2) for i, _ in ((1, "a"), (2, "b"), (3, "c")))
(((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3)) (((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3))
(*starred) (*starred,)
-{"id": "1","type": "type","started_at": now(),"ended_at": now() + timedelta(days=10),"priority": 1,"import_session_id": 1,**kwargs} -{"id": "1","type": "type","started_at": now(),"ended_at": now() + timedelta(days=10),"priority": 1,"import_session_id": 1,**kwargs}
+{ +{
+ "id": "1", + "id": "1",

4
tests/data/expression.py
View File

@ -146,7 +146,7 @@
((i ** 2) for i in (1, 2, 3)) ((i ** 2) for i in (1, 2, 3))
((i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c'))) ((i ** 2) for i, _ in ((1, 'a'), (2, 'b'), (3, 'c')))
(((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3)) (((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3))
(*starred) (*starred,)
{"id": "1","type": "type","started_at": now(),"ended_at": now() + timedelta(days=10),"priority": 1,"import_session_id": 1,**kwargs} {"id": "1","type": "type","started_at": now(),"ended_at": now() + timedelta(days=10),"priority": 1,"import_session_id": 1,**kwargs}
a = (1,) a = (1,)
b = 1, b = 1,
@ -431,7 +431,7 @@ async def f():
((i ** 2) for i in (1, 2, 3)) ((i ** 2) for i in (1, 2, 3))
((i ** 2) for i, _ in ((1, "a"), (2, "b"), (3, "c"))) ((i ** 2) for i, _ in ((1, "a"), (2, "b"), (3, "c")))
(((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3)) (((i ** 2) + j) for i in (1, 2, 3) for j in (1, 2, 3))
(*starred) (*starred,)
{ {
"id": "1", "id": "1",
"type": "type", "type": "type",