actions/black
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Treat walruses like other binary operators in subscripts (#4109)

Browse Source 
Fixes #4078
This commit is contained in:
cobalt 2023-12-28 00:24:25 -06:00 committed by GitHub
parent 51786141cc
commit c80685f361
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES.md
View File

@ -14,6 +14,9 @@
<!-- Changes that affect Black's preview style --> <!-- Changes that affect Black's preview style -->
- Fix bug where spaces were not added around parenthesized walruses in subscripts,
unlike other binary operators (#4109)
### Configuration ### Configuration
<!-- Changes to how Black can be configured --> <!-- Changes to how Black can be configured -->

9
src/black/lines.py
View File

@ -446,8 +446,15 @@ def is_complex_subscript(self, leaf: Leaf) -> bool:
if subscript_start.type == syms.subscriptlist: if subscript_start.type == syms.subscriptlist:
subscript_start = child_towards(subscript_start, leaf) subscript_start = child_towards(subscript_start, leaf)
# When this is moved out of preview, add syms.namedexpr_test directly to
# TEST_DESCENDANTS in nodes.py
if Preview.walrus_subscript in self.mode:
test_decendants = TEST_DESCENDANTS | {syms.namedexpr_test}
else:
test_decendants = TEST_DESCENDANTS
return subscript_start is not None and any( return subscript_start is not None and any(
n.type in TEST_DESCENDANTS for n in subscript_start.pre_order() n.type in test_decendants for n in subscript_start.pre_order()
) )
def enumerate_with_length( def enumerate_with_length(

4
tests/data/cases/preview_pep_572.py
View File

@ -3,5 +3,5 @@
x[:(a:=0)] x[:(a:=0)]
# output # output
x[(a := 0):] x[(a := 0) :]
x[:(a := 0)] x[: (a := 0)]