Remove blib2to3 grammar cache logging (#3193)
As error logs are emitted often (they happen when Black's cache directory is created after blib2to3 tries to write its cache) and cause issues to be filed by users who think Black isn't working correctly. These errors are expected for now and aren't a cause for concern so let's remove them to stop worrying users (and new issues from being opened). We can improve the blib2to3 caching mechanism to write its cache at the end of a successful command line invocation later.
This commit is contained in:
parent
4f1772e2ae
commit
d85cf00ee8
@ -54,6 +54,8 @@
|
||||
|
||||
- Change from deprecated `asyncio.get_event_loop()` to create our event loop which
|
||||
removes DeprecationWarning (#3164)
|
||||
- Remove logging from internal `blib2to3` library since it regularily emits error logs
|
||||
about failed caching that can and should be ignored (#3193)
|
||||
|
||||
### Packaging
|
||||
|
||||
|
@ -263,14 +263,13 @@ def load_grammar(
|
||||
logger = logging.getLogger(__name__)
|
||||
gp = _generate_pickle_name(gt) if gp is None else gp
|
||||
if force or not _newer(gp, gt):
|
||||
logger.info("Generating grammar tables from %s", gt)
|
||||
g: grammar.Grammar = pgen.generate_grammar(gt)
|
||||
if save:
|
||||
logger.info("Writing grammar tables to %s", gp)
|
||||
try:
|
||||
g.dump(gp)
|
||||
except OSError as e:
|
||||
logger.info("Writing failed: %s", e)
|
||||
except OSError:
|
||||
# Ignore error, caching is not vital.
|
||||
pass
|
||||
else:
|
||||
g = grammar.Grammar()
|
||||
g.load(gp)
|
||||
|
Loading…
Reference in New Issue
Block a user