actions/black
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Wrap loop.run_in_executor up in asyncio.ensure_future for reliable cross-platform berhavior. (#679)

Browse Source 
Closes #494

Task completion should also remove the task from `pending`.

Only replicates on some platforms. (eg. Can replicate on Python 3.7+, with either Windows or whatever default Linux distro Travis uses.)
This commit is contained in:
Tom Christie 2019-05-05 19:58:26 +01:00 committed by Jelle Zijlstra
parent 4a953b7241
commit e6ddb68c78
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
black.py
View File

@ -526,12 +526,14 @@ async def schedule_formatting(
manager = Manager() manager = Manager()
lock = manager.Lock() lock = manager.Lock()
tasks = { tasks = {
loop.run_in_executor( asyncio.ensure_future(
executor, format_file_in_place, src, fast, mode, write_back, lock loop.run_in_executor(
executor, format_file_in_place, src, fast, mode, write_back, lock
)
): src ): src
for src in sorted(sources) for src in sorted(sources)
} }
pending: Iterable[asyncio.Task] = tasks.keys() pending: Iterable[asyncio.Future] = tasks.keys()
try: try:
loop.add_signal_handler(signal.SIGINT, cancel, pending) loop.add_signal_handler(signal.SIGINT, cancel, pending)
loop.add_signal_handler(signal.SIGTERM, cancel, pending) loop.add_signal_handler(signal.SIGTERM, cancel, pending)