actions/black
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove slow assertion (#1592)

Browse Source 
Partial fix for #1581

This assertion produces behavior quadratic in the number of leaves in a line, which is making Black extremely slow on files with very long expressions. On my benchmark file this change makes Black 10x faster.
This commit is contained in:
Jelle Zijlstra 2020-08-12 19:12:21 -07:00 committed by GitHub
parent b59a524657
commit f825e7ef28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/black/__init__.py
View File

@ -4594,8 +4594,6 @@ def append_leaves(new_line: Line, old_line: Line, leaves: List[Leaf]) -> None:
set(@leaves) is a subset of set(@old_line.leaves).
"""
for old_leaf in leaves:
assert old_leaf in old_line.leaves
new_leaf = Leaf(old_leaf.type, old_leaf.value)
replace_child(old_leaf, new_leaf)
new_line.append(new_leaf)