db30456916
Black would previously strip the parenthesis away from statements like this these ones:
assert (spam := 12 + 1)
return (cheese := 1 - 12)
Which happens to be invalid code. Now before making the parenthesis invisible, Black
checks if the assignment expression's parent is an assert stamtment, aborting if True.
Raise, yield, and await are already handled fine.
I added a bunch of test cases from the PEP defining asssignment expressions (PEP 572).
91 lines
1.1 KiB
Python
91 lines
1.1 KiB
Python
if (foo := 0):
|
|
pass
|
|
|
|
if (foo := 1):
|
|
pass
|
|
|
|
if (y := 5 + 5):
|
|
pass
|
|
|
|
y = (x := 0)
|
|
|
|
y += (x := 0)
|
|
|
|
(y := 5 + 5)
|
|
|
|
test: int = (test2 := 2)
|
|
|
|
a, b = (test := (1, 2))
|
|
|
|
# see also https://github.com/psf/black/issues/2139
|
|
assert (foo := 42 - 12)
|
|
|
|
foo(x=(y := f(x)))
|
|
|
|
|
|
def foo(answer=(p := 42)):
|
|
...
|
|
|
|
|
|
def foo2(answer: (p := 42) = 5):
|
|
...
|
|
|
|
|
|
lambda: (x := 1)
|
|
|
|
# we don't touch expressions in f-strings but if we do one day, don't break 'em
|
|
f'{(x:=10)}'
|
|
|
|
|
|
def a():
|
|
return (x := 3)
|
|
await (b := 1)
|
|
yield (a := 2)
|
|
raise (c := 3)
|
|
|
|
# output
|
|
if foo := 0:
|
|
pass
|
|
|
|
if foo := 1:
|
|
pass
|
|
|
|
if y := 5 + 5:
|
|
pass
|
|
|
|
y = (x := 0)
|
|
|
|
y += (x := 0)
|
|
|
|
(y := 5 + 5)
|
|
|
|
test: int = (test2 := 2)
|
|
|
|
a, b = (test := (1, 2))
|
|
|
|
# see also https://github.com/psf/black/issues/2139
|
|
assert (foo := 42 - 12)
|
|
|
|
foo(x=(y := f(x)))
|
|
|
|
|
|
def foo(answer=(p := 42)):
|
|
...
|
|
|
|
|
|
def foo2(answer: (p := 42) = 5):
|
|
...
|
|
|
|
|
|
lambda: (x := 1)
|
|
|
|
# we don't touch expressions in f-strings but if we do one day, don't break 'em
|
|
f"{(x:=10)}"
|
|
|
|
|
|
def a():
|
|
return (x := 3)
|
|
await (b := 1)
|
|
yield (a := 2)
|
|
raise (c := 3)
|