
I know I know, this is the second reorganization of the docs. I'm not saying the first one was bad or anything... but.. actually wait nah, *it was bad*. Anyway, welcome to probably my biggest commit. The main thing with this reorganization was to introduce nesting to the documentation! Having all of the docs be part of the main TOC was becoming too much. There wasn't much room to expand either. Finally, the old setup required a documentation generation step which was just annoying. The goals of this reorganization was to: 1. Significantly restructure the docs to be discoverable and understandable 2. Add room for further docs (like guides or contributing docs) 3. Get rid of the doc generation step (it was slow and frustrating) 4. Unblock other improvements and also just make contributing to the docs easier Another important change with this is that we are no longer using GitHub as a documentation host. While GitHub does support Markdown based docs actually pretty well, the lack of any features outside of GitHub Flavoured Markdown is quite limiting. ReadTheDocs is just much better suited for documentation. You can use reST, MyST, CommonMark, and all of their great features like toctrees and admonitions. Related to this change, we're adopting MyST as our flavour of Markdown. MyST introduces neat syntax extensions to Markdown that pretty much gives us the best of both worlds. The ease of use and simplicity of MD and the flexibility and expressiveness of reST. Also recommonmark is deprecated now. This switch was possible now we don't use GH as a docs host. MyST docs have to be built to really be usable / pretty, so the MD docs are going to look pretty bad on GH, but that's fine now! Another thing that should be noted is that the README has been stripped of most content since it was confusing. Users would read the README and then think some feature or bug was fixed already and is available in a release when in reality, they weren't. They were reading effectively the latest docs without knowing. See also: https://github.com/psf/black/issues/1759 FYI: CommonMark is a rationalized version of Markdown syntax -- Commit history before merge: * Switch to MyST-Parser + doc config cleanup recommonmark is being deprecated in favour of MyST-Parser. This change is welcomed, especially since MyST-Parser has syntax extensions for the Commonmark standard. Effectively we get to use a language that's powerful and expressive like ReST, but get the simplicity of Markdown. The rest of this effort will be using some MyST features. This reorganization efforts aims to remove as much duplication as possible. The regeneration step once needed is gone, significantly simplifing our Sphinx documentation configuration. * Tell pipenv we replaced recommonmark for MyST-Parser Also update `docs/requirements.txt` * Delete all auto generated content * Switch prettier for mdformat (plus a few plugins) **FYI: THIS WAS EFFECTIVELY REVERTED, SEE THIRD TO LAST COMMIT** prettier doesn't support MyST's syntax extensions which are going to be used in this reorganization effort so we have to switch formatter. Unfortanately mdformat's style is different from prettier's so time to reformat the whole repo too. We're excluding .github/ISSUE_TEMPLATE because I have no idea whether its changes are safe, so let's play it safe. * Fix the heading levels in CHANGES.md + a link MyST-Parser / sphinx's linkcheck complains otherwise. * Move reference docs into a docs/contributing dir They're for contributors of Black anyway. Also added a note in the summary document warning about the lack of attention the reference has been dealing with. * Rewrite and setup the new landing page + main TOC - add some more detail about Black's beta status - add licensing info - add external links in the main TOC for GitHub, PyPI, and IRC - prepare main TOC for new structure * Break out AUTHORS into its own file Not only was the AUTHORS list quite long, this makes it easy to include it in the Sphinx docs with just a simple symlink. * Add license to docs via a simple include Yes the document is orphaned but it is linked to in the landing page (docs/index.rst). * Add "The Black Code Style" section This mostly was a restructuring commit, there has been a few updates but not many. The main goal was to split "current style" and "planned changes to the style that haven't happened yet" to avoid confusion. * Add "Getting Started" page This is basically a quick start + even more. This commit is certainly one of most creatively involved in this effort. * Add "Usage and Configuration" section This commit was as much restructuring as new content. Instead of being in one giant file, usage and configuration documentation can expand without bloating a single file. * Add "Integrations" section Just a restructuring commit ... * Add "Guides" section This is a promising area of documentation that could easily grow in the future, let's prepare for that! * Add "Contributing" section This is also another area that I expect to see significant growth in. Contributors to Black could definitely do with some more specific docs that clears up certain parts of our slightly confusing project (it's only confusing because we're getting big and old!). * Rewrite CONTRIBUTING.md to just point to RTD * Rewrite README.md to delegate most info to RTD * Address feedback + a lot of corrections and edits I know I said I wanted to do these after landing this but given there's going to be no time between this being merged and a release getting pushed, I want these changes to make it in. - drop the number flag for mdformat - to reduce diffs, see also: https://mdformat.readthedocs.io/en/stable/users/style.html#ordered-lists - the GH issue templates should be safe by mdformat, so get rid of the exclude - clarify our configuration position - i.e. stop claiming we don't have many options, instead say we want as little formatting knobs as possible - lots and lots of punctuation, spelling, and grammar corrections (thanks Jelle!) - use RTD as the source for the CHANGELOG too - visual style cleanups - add docs about our .gitignore behaviour - expand GHA Action docs - clarify we want the PR number in the CHANGELOG entry - claify Black's behaviour for with statements post Python 3.9 - italicize a bunch of "Black"s Thank you goes to Jelle, Taneli (hukkinj1 on GH), Felix (felix-hilden on GH), and Wouter (wbolster on GH) for the feedback! * Merge remote-tracking branch 'upstream/master' into reorganize-docs-v2 merge conflicts suck, although these ones weren't too bad. * Add changelog entry + fix merge conflict resolution error I consider this important enough to be worthy of a changelog entry :) * Merge branch 'master' into reorganize-docs-v2 Co-authored-by: Łukasz Langa <lukasz@langa.pl> * Actually let's continue using prettier Prettier works fine for all of the default MyST syntax so let's not rock the boat as much. Dropping the mdformat commit was merge-conflict filled so here's additional commit instead. * Address Cooper's, Taneli's, and Jelle's feedback Lots of wording improvements by Cooper. Taneli suggested to disable the enabled by default MyST syntax not supported by Prettier and I agreed. And Jelle found one more spelling error! * More minor fixes
7.1 KiB
Using Black with other tools
Black compatible configurations
All of Black's changes are harmless (or at least, they should be), but a few do conflict against other tools. It is not uncommon to be using other tools alongside Black like linters and type checkers. Some of them need a bit of tweaking to resolve the conflicts. Listed below are Black compatible configurations in various formats for the common tools out there.
Please note that Black only supports the TOML file format for its configuration
(e.g. pyproject.toml
). The provided examples are to only configure their corresponding
tools, using their supported file formats.
Compatible configuration files can be found here.
isort
isort helps to sort and format imports in your Python code. Black also formats imports, but in a different way from isort's defaults which leads to conflicting changes.
Profile
Since version 5.0.0, isort supports
profiles to allow easy
interoperability with common code styles. You can set the black profile in any of the
config files supported
by isort. Below, an example for pyproject.toml
:
[tool.isort]
profile = "black"
Custom Configuration
If you're using an isort version that is older than 5.0.0 or you have some custom
configuration for Black, you can tweak your isort configuration to make it compatible
with Black. Below, an example for .isort.cfg
:
multi_line_output = 3
include_trailing_comma = True
force_grid_wrap = 0
use_parentheses = True
ensure_newline_before_comments = True
line_length = 88
Why those options above?
Black wraps imports that surpass line-length
by moving identifiers into their own
indented line. If that still doesn't fit the bill, it will put all of them in separate
lines and put a trailing comma. A more detailed explanation of this behaviour can be
found here.
isort's default mode of wrapping imports that extend past the line_length
limit is
"Grid".
from third_party import (lib1, lib2, lib3,
lib4, lib5, ...)
This style is incompatible with Black, but isort can be configured to use a different wrapping mode called "Vertical Hanging Indent" which looks like this:
from third_party import (
lib1,
lib2,
lib3,
lib4,
)
This style is Black compatible and can be achieved by multi-line-output = 3
. Also,
as mentioned above, when wrapping long imports Black puts a trailing comma and uses
parentheses. isort should follow the same behaviour and passing the options
include_trailing_comma = True
and use_parentheses = True
configures that.
The option force_grid_wrap = 0
is just to tell isort to only wrap imports that surpass
the line_length
limit.
Finally, isort should be told to wrap imports when they surpass Black's default limit
of 88 characters via line_length = 88
as well as
ensure_newline_before_comments = True
to ensure spacing import sections with comments
works the same as with Black.
Please note ensure_newline_before_comments = True
only works since isort >= 5 but
does not break older versions so you can keep it if you are running previous versions.
Formats
.isort.cfg
[settings]
profile = black
setup.cfg
[isort]
profile = black
pyproject.toml
[tool.isort]
profile = 'black'
.editorconfig
[*.py]
profile = black
Flake8
Flake8 is a code linter. It warns you of syntax errors, possible bugs, stylistic errors, etc. For the most part, Flake8 follows PEP 8 when warning about stylistic errors. There are a few deviations that cause incompatibilities with Black.
Configuration
max-line-length = 88
extend-ignore = E203
Why those options above?
In some cases, as determined by PEP 8, Black will enforce an equal amount of
whitespace around slice operators. Due to this, Flake8 will raise
E203 whitespace before ':'
warnings. Since this warning is not PEP 8 compliant, Flake8
should be configured to ignore it via extend-ignore = E203
.
When breaking a line, Black will break it before a binary operator. This is compliant
with PEP 8 as of
April 2016.
There's a disabled-by-default warning in Flake8 which goes against this PEP 8
recommendation called W503 line break before binary operator
. It should not be enabled
in your configuration.
Also, as like with isort, flake8 should be configured to allow lines up to the length
limit of 88
, Black's default. This explains max-line-length = 88
.
Formats
.flake8
[flake8]
max-line-length = 88
extend-ignore = E203
setup.cfg
[flake8]
max-line-length = 88
extend-ignore = E203
tox.ini
[flake8]
max-line-length = 88
extend-ignore = E203
Pylint
Pylint is also a code linter like Flake8. It has the same checks as flake8 and more. In particular, it has more formatting checks regarding style conventions like variable naming. With so many checks, Pylint is bound to have some mixed feelings about Black's formatting style.
Configuration
disable = C0330, C0326
max-line-length = 88
Why those options above?
When Black is folding very long expressions, the closing brackets will be dedented.
ImportantClass.important_method(
exc, limit, lookup_lines, capture_locals, callback
)
Although this style is PEP 8 compliant, Pylint will raise
C0330: Wrong hanging indentation before block (add 4 spaces)
warnings. Since Black
isn't configurable on this style, Pylint should be told to ignore these warnings via
disable = C0330
.
Also, since Black deals with whitespace around operators and brackets, Pylint's
warning C0326: Bad whitespace
should be disabled using disable = C0326
.
And as usual, Pylint should be configured to only complain about lines that surpass 88
characters via max-line-length = 88
.
Formats
pylintrc
[MESSAGES CONTROL]
disable = C0330, C0326
[format]
max-line-length = 88
setup.cfg
[pylint]
max-line-length = 88
[pylint.messages_control]
disable = C0330, C0326
pyproject.toml
[tool.pylint.messages_control]
disable = "C0330, C0326"
[tool.pylint.format]
max-line-length = "88"